nix-profile-daemon.fish: XDG_DATA_DIRS: .profile/share #12414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems reasonable to add the `share` folder from the user profile into `$XDG_DATA_DIRS` both for daemon and profile execution. Nix could add package shared files into this folder regardless of how the nix daemon itself is running.
edolstra
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seems reasonable to add the
sharefolder from the user profile into$XDG_DATA_DIRSboth for daemon and profile execution. Nix could add package shared files into this folder regardless of how the nix daemon itself is running.This change reduces the differences between
nix-profile-daemon.fishandnix-profil.fishto the following:https://gist.github.com/ilya-bobyr/c957a9f998b85833064b2d64b4ae4062#file-nix-profile-fish-2-diff
Context
This is related to point 6 in the issue where the difference between daemon and non-daemon profiles are listed.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.