Simplify state machine 2 #12412
Merged
Simplify state machine 2 #12412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary in order to inline `inputsRealised` in the next commit by combing it with its adjacent function (i.e. with a small diff).
|
🎉 All dependencies have been resolved ! |
|
Can you rebase this PR? |
|
@edolstra no need for a rebase :) just reset the target branch to master and the diff shrunk. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up from #12392, see that for motivation.
The first commit moves the function out of the way. The second joins together now-adjacent functions into a single larger function.
Context
Depends on #12392
These last two commits were split out because they (necessarily) have a bigger diff.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.