-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: add back an x86-64_darwin
runner
#11144
base: master
Are you sure you want to change the base?
Conversation
Thanks! Note that you could potentially get faster CI by still using an AArch64 runner and just passing |
ec5e01b
to
530ec23
Compare
(Probably that third commit isn’t meant to be here?) |
That was for troubleshooting this failure EDIT: which happened again on e48e0cb |
Interestingly hydra doesn't experience these build failures, so I think we just don't support macOS 13 anymore. |
Dropping support for macOS 13 would be pretty brutal since it’s been at 10.12 for the longest time and Apple supports back to macOS 12. We definitely don’t currently have consensus on the Nixpkgs side to even drop support for pre‐macOS 11 (although I’d personally support such a move). I’m not sure why the runner OS version would matter that much, though; the build goes through the Nixpkgs machinery, right? In which case it should still be using an old SDK no matter what OS version it’s being built on. |
x86-64_darwin
runnerx86-64_darwin
runner
GHA has previously upgraded us to aarch64 (silently; that was fun), but we're running into issues with x86_64-darwin, so we really have to re-enable that as well.
530ec23
to
1474e5c
Compare
Motivation
x86_64-darwin build had an issue.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.