Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: add back an x86-64_darwin runner #11144

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roberth
Copy link
Member

@roberth roberth commented Jul 20, 2024

Motivation

x86_64-darwin build had an issue.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@emilazy
Copy link
Member

emilazy commented Jul 20, 2024

Thanks! Note that you could potentially get faster CI by still using an AArch64 runner and just passing --system x86_64-linux, which works seamlessly with Rosetta 2. It depends on what hardware GitHub uses for runners, though.

@github-actions github-actions bot added repl The Read Eval Print Loop, "nix repl" command and debugger fetching Networking with the outside (non-Nix) world, input locking labels Jul 20, 2024
@roberth roberth force-pushed the gha-x86_64-darwin branch from ec5e01b to 530ec23 Compare July 20, 2024 20:58
@emilazy
Copy link
Member

emilazy commented Jul 20, 2024

(Probably that third commit isn’t meant to be here?)

@roberth
Copy link
Member Author

roberth commented Jul 22, 2024

(Probably that third commit isn’t meant to be here?)

That was for troubleshooting this failure

EDIT: which happened again on e48e0cb

@roberth
Copy link
Member Author

roberth commented Jul 22, 2024

Interestingly hydra doesn't experience these build failures, so I think we just don't support macOS 13 anymore.
Unfortunately that's the only version for which GitHub has free runners that are native x86_64 machines.
This is not a requirement for the build though, so perhaps we could build with Rosetta, and then perform the installer test on a native machine. Either way, we'll have to be more explicit about the platforms we support in doc/manual/src/installation/supported-platforms.md

@emilazy
Copy link
Member

emilazy commented Jul 22, 2024

Dropping support for macOS 13 would be pretty brutal since it’s been at 10.12 for the longest time and Apple supports back to macOS 12. We definitely don’t currently have consensus on the Nixpkgs side to even drop support for pre‐macOS 11 (although I’d personally support such a move). I’m not sure why the runner OS version would matter that much, though; the build goes through the Nixpkgs machinery, right? In which case it should still be using an old SDK no matter what OS version it’s being built on.

@roberth roberth changed the title GitHub Actions: re-add an x86-64_darwin runner GitHub Actions: add back an x86-64_darwin runner Jul 24, 2024
roberth added 2 commits July 30, 2024 05:11
GHA has previously upgraded us to aarch64 (silently; that was fun),
but we're running into issues with x86_64-darwin, so we really have
to re-enable that as well.
@roberth roberth force-pushed the gha-x86_64-darwin branch from 530ec23 to 1474e5c Compare July 30, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetching Networking with the outside (non-Nix) world, input locking repl The Read Eval Print Loop, "nix repl" command and debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants