Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use self-descriptive name for config file parser, document #11037

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

fricklerhandwerk
Copy link
Contributor

Motivation

trying to figure out where values come from, in order to write tests for fixing #9574

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@fricklerhandwerk fricklerhandwerk added documentation contributor-experience Developer experience for Nix contributors labels Jul 4, 2024
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We paired on this for ~2 hours with the goal of fixing NIX_PATH, which shows how impenetrable the setting system is.
Simplification is needed. We love you @Ericson2314

@roberth roberth added the settings Settings, global flags, nix.conf label Jul 5, 2024
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Ericson2314 Ericson2314 merged commit ff9b6d0 into NixOS:master Jul 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors documentation settings Settings, global flags, nix.conf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants