-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typlite): render context block contextually #1305
Merged
Myriad-Dreamin
merged 13 commits into
Myriad-Dreamin:main
from
hongjr03:better-contextual-render
Feb 19, 2025
Merged
feat(typlite): render context block contextually #1305
Myriad-Dreamin
merged 13 commits into
Myriad-Dreamin:main
from
hongjr03:better-contextual-render
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe8da10
to
b6779b2
Compare
b6779b2
to
cf0cb14
Compare
Myriad-Dreamin
approved these changes
Feb 18, 2025
Ident | Bool | Int | Float | Numeric | Str | Array | Dict | ||
) | ||
{ | ||
self.prepend_code += node.clone().into_text(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code here has bad performance. Assuming there are
Myriad-Dreamin
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better contexual render
I introduced an
EcoString
to store the codes of nodes that result inValue::None
(excludingIdent | Bool | Int | Float | Numeric | Str | Array | Dict
andHash
at the beginning of#context
) that appear before aContextual
node. Then prepend the buffer to theContextual
node to render in right environment.Add assets_path and assets_src_path to args and TypliteFeat, support render contexual code to external svg file.
Variable names were chosen quickly and are not ideal apparently, sorry for that :(