Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add type field to all placeholders in arb #246

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

balthild
Copy link
Contributor

@balthild balthild commented Feb 19, 2025

I was unable to build the project when this field is missing.

Summary by Sourcery

Bug Fixes:

  • Adds the missing type field to all placeholders in the Application Resource Bundle (ARB) files.

Copy link

sourcery-ai bot commented Feb 19, 2025

Reviewer's Guide by Sourcery

This pull request adds the type field to all placeholders defined in the Application Resource Bundle (ARB) files. This change ensures that each placeholder explicitly declares its data type, improving type safety and clarity in localization.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added type field to all placeholders in ARB files.
  • Added type field to placeholders in intl_de.arb.
  • Added type field to placeholders in intl_en.arb.
  • Added type field to placeholders in intl_en_EO.arb.
  • Added type field to placeholders in intl_fr.arb.
  • Added type field to placeholders in intl_it.arb.
  • Added type field to placeholders in intl_ja.arb.
  • Added type field to placeholders in intl_ja_Kana.arb.
  • Added type field to placeholders in intl_ja_Nise.arb.
  • Added type field to placeholders in intl_ko.arb.
  • Added type field to placeholders in intl_uk.arb.
  • Added type field to placeholders in intl_zh_Hans.arb.
  • Added type field to placeholders in intl_zh_Hant_LZH.arb.
  • Added type field to placeholders in intl_zh_Hant_NAN.arb.
  • Added type field to placeholders in intl_zh_Hant_TW.arb.
  • Added type field to placeholders in intl_zh_Hant_YUE.arb.
lib/l10n/intl_de.arb
lib/l10n/intl_en.arb
lib/l10n/intl_en_EO.arb
lib/l10n/intl_fr.arb
lib/l10n/intl_it.arb
lib/l10n/intl_ja.arb
lib/l10n/intl_ja_Kana.arb
lib/l10n/intl_ja_Nise.arb
lib/l10n/intl_ko.arb
lib/l10n/intl_uk.arb
lib/l10n/intl_zh_Hans.arb
lib/l10n/intl_zh_Hant_LZH.arb
lib/l10n/intl_zh_Hant_NAN.arb
lib/l10n/intl_zh_Hant_TW.arb
lib/l10n/intl_zh_Hant_YUE.arb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @balthild - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot bot added the C - l10n Localization related issue label Feb 19, 2025
@Losses Losses merged commit c1e2061 into Losses:master Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - l10n Localization related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants