nix-daemon: increase SoftResourceLimits.NumberOfFiles #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
reviewed
Oct 28, 2024
| @@ -51,7 +51,7 @@ in | |||
| serviceConfig.ProcessType = config.nix.daemonProcessType; | |||
| serviceConfig.LowPriorityIO = config.nix.daemonIOLowPriority; | |||
| serviceConfig.Label = "org.nixos.nix-daemon"; # must match daemon installed by Nix regardless of the launchd label Prefix | |||
| serviceConfig.SoftResourceLimits.NumberOfFiles = mkDefault 4096; | |||
| serviceConfig.SoftResourceLimits.NumberOfFiles = mkDefault 1048576; | |||
There was a problem hiding this comment.
In nixpkgs stdenv room we're wondering if this is even doing anything
It did not work before NixOS/nix#6645 as shown by issue NixOS/nix#6557
$ nix build --impure --expr 'with (builtins.getFlake "nixpkgs").legacyPackages.x86_64-darwin; runCommand "x" {} "ulimit -a > $out"' -L
$ cat result
core file size (blocks, -c) 0
data seg size (kbytes, -d) unlimited
file size (blocks, -f) unlimited
max locked memory (kbytes, -l) unlimited
max memory size (kbytes, -m) unlimited
open files (-n) 1048576
pipe size (512 bytes, -p) 1
stack size (kbytes, -s) 8192
cpu time (seconds, -t) unlimited
max user processes (-u) 5568
virtual memory (kbytes, -v) unlimitedSeems to be a hydra problem https://matrix.to/#/!OqhvaDMJdKYUicLDiE:nixos.org/$NueHaidIZChpEHdOYgyDIDNHVrhq6eyQm7wF1fNzhQU?via=nixos.org&via=matrix.org&via=nixos.dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1048576 matches the nixos/nix plist
https://github.com/NixOS/nix/blob/e3a4e40a354e1c2d177541d24d6a86a001fa87c7/misc/launchd/org.nixos.nix-daemon.plist.in#L29