-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NSStatusItemSpacing and NSStatusItemSelectionPadding #872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the two commits into one? It looks like they're exactly the same
default = null; | ||
example = 12; | ||
description = lib.mdDoc '' | ||
Sets the spacing between status icons in the menu bar. The default is null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should specify the macOS default like the rest of the options
nix-darwin/modules/system/defaults/NSGlobalDomain.nix
Lines 11 to 17 in 44f50a5
system.defaults.NSGlobalDomain.AppleShowAllFiles = mkOption { | |
type = types.nullOr types.bool; | |
default = null; | |
description = lib.mdDoc '' | |
Whether to always show hidden files. The default is false. | |
''; | |
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are the MacOS defaults. Both of these options are unset by default.
Done. Apologies for the delay, I was travelling all last week. |
You should squash the commit removing |
Add `NSStatusItemSpacing` and `NSStatusItemSelectionPadding` to `NSGlobalDomain` options. These options control the spacing between and padding inside status icons in the menu bar. With these options, it's possible to squeeze more items on the menu bar, something that's especially useful on machines with a notch. This is a copy of LnL7#872, which was closed without being merged.
Add
NSStatusItemSpacing
andNSStatusItemSelectionPadding
toNSGlobalDomain
options.These options control the spacing between and padding inside status icons in the menu bar. With these options it's possible to squeeze more items on to menu bar, something that's especially useful on machines with a notch!