Add support for persistent-apps in dock #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
force-pushed
the
dock-persistent-apps
branch
2 times, most recently
from
6a4e3b7 to
e2ee49a
Compare
dfrankland
force-pushed
the
dock-persistent-apps
branch
3 times, most recently
from
de7bd8e to
aaf9d1a
Compare
|
I was looking to use this setting. Has development stopped in this PR? |
|
A lot of tests have to be re-written for this to be totally ready to merge. Besides that, probably just a rebase. Would be lovely to get the maintainers' opinion on #790 before re-writing all of the tests. |
dfrankland
force-pushed
the
dock-persistent-apps
branch
from
aaf9d1a to
31f8c7f
Compare
Complex container values like `-array` have their own DSL which does not allow specifying all data types. Instead of using the DSL use plist fragments instead.
dfrankland
force-pushed
the
dock-persistent-apps
branch
from
31f8c7f to
e2d12aa
Compare
|
I had to rebase, redo a bit of the implementation for testing, and finally added tests. New PR is opened up here: #898 |
|
For anyone following this PR, the newer PR #898 got merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications added to the dock point to an old derivation when a new derivation of an application is added to the Nix store. This allows configuring the persistent applications to display system apps or apps in the Nix store.
Updates require re-login or restarting the Dock process e.g.
killall Dock.Dependent on:
#790
Related / supersedes:
#590
#616