services/dnscrypt-proxy: init #1343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
requested changes
Feb 18, 2025
r17x
force-pushed
the
feat/dnscrypt-proxy
branch
from
ea77b46 to
30922eb
Compare
emilazy
requested changes
Feb 18, 2025
Comment on lines
+46
to
+54
| launchd.daemons.dnscrypt-proxy = { | ||
| script = '' | ||
| ${lib.getExe' cfg.package "dnscrypt-proxy"} -config ${configFile} | ||
| ''; | ||
| serviceConfig = { | ||
| RunAtLoad = true; | ||
| KeepAlive = true; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
This should have its own user assigned and run as that user; there’s no reason for dnscrypt-proxy to run as root. See e.g. modules/services/monitoring/prometheus-node-exporter.nix for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have been using dnscrypt-proxy with nix-darwin on my own configuration. I just want to start contribution in nix-darwin.
Thank you