users: use launchctl managername to determine session type
#1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
force-pushed
the
push-vykszlnztmtt
branch
from
4aa8396 to
3e788d3
Compare
emilazy
force-pushed
the
push-vykszlnztmtt
branch
from
3e788d3 to
7b050d8
Compare
Enzime
requested changes
Feb 7, 2025
Seems like this should be more robust, and it will work even after the activation script purifies its environment. Apparently it may treat `tmux` sessions like SSH ones, which may have something to do with `reattach-to-user-namespace`/`pam_reattach`; see <ChrisJohnsen/tmux-MacOSX-pasteboard#78 (comment)>. (My hope is that `pam_reattach` does the right thing here, but I haven’t tested.)
emilazy
force-pushed
the
push-vykszlnztmtt
branch
from
7b050d8 to
d634e28
Compare
emilazy
changed the title
sudo invocations, use launchctl managername to determine session typelaunchctl managername to determine session type
Enzime
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.