-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{environment,readme}: default configuration path to /etc/nix-darwin
#1280
Conversation
This is running into the thing where we test installation against the branch base. Not sure if we should fix that or what. (Testing upgrades seems like a good thing, but in this case the way it’s done is kind of annoying.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree with the idea of the PR.
I don't feel completely confident in my understanding of the interaction of all these moving parts, though; what I read through seems good but I'm wondering if people will run into issues due to this change given the note on the environment.darwinConfig
option:
NOTE: Changing this requires running
darwin-rebuild switch -I darwin-config=/path/to/configuration.nix
the first time to make darwin-rebuild aware of the custom location.
Given the stateVersion
condition, I imagine nobody will run into issues unless they update their stateVersion
, in which case perhaps they're just on their own?
Yeah if you bump |
6414c67
to
bf6f554
Compare
Realized that we were telling people to install 24.11 with the unstable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for making this change, been on my list for so long 👍
bf6f554
to
544a880
Compare
544a880
to
3509925
Compare
Split off from The Plan stack, where it becomes more important, but a good idea anyway given our general direction and to align the default between flake‐ and channel‐based setups. This is not a breaking change thanks to the
system.stateVersion
conditional (unless anyone is looking atenvironment.darwinConfig
on a flake‐based setup, which I guess is possible although seems inadvisable), so we can do it now.