Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{environment,readme}: default configuration path to /etc/nix-darwin #1280

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

emilazy
Copy link
Collaborator

@emilazy emilazy commented Jan 18, 2025

Split off from The Plan stack, where it becomes more important, but a good idea anyway given our general direction and to align the default between flake‐ and channel‐based setups. This is not a breaking change thanks to the system.stateVersion conditional (unless anyone is looking at environment.darwinConfig on a flake‐based setup, which I guess is possible although seems inadvisable), so we can do it now.

@emilazy emilazy requested a review from Enzime January 18, 2025 19:48
@emilazy
Copy link
Collaborator Author

emilazy commented Jan 18, 2025

This is running into the thing where we test installation against the branch base. Not sure if we should fix that or what. (Testing upgrades seems like a good thing, but in this case the way it’s done is kind of annoying.)

Copy link
Contributor

@Samasaur1 Samasaur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely agree with the idea of the PR.

I don't feel completely confident in my understanding of the interaction of all these moving parts, though; what I read through seems good but I'm wondering if people will run into issues due to this change given the note on the environment.darwinConfig option:

NOTE: Changing this requires running darwin-rebuild switch -I darwin-config=/path/to/configuration.nix the first time to make darwin-rebuild aware of the custom location.

Given the stateVersion condition, I imagine nobody will run into issues unless they update their stateVersion, in which case perhaps they're just on their own?

@emilazy
Copy link
Collaborator Author

emilazy commented Jan 20, 2025

Yeah if you bump system.stateVersion without reading the changelog it's expected that stuff will explode.

@emilazy
Copy link
Collaborator Author

emilazy commented Jan 20, 2025

Realized that we were telling people to install 24.11 with the unstable darwin-rebuild. Whoops! Fixed.

Enzime
Enzime previously approved these changes Jan 23, 2025
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for making this change, been on my list for so long 👍

@emilazy emilazy merged commit f43dac4 into LnL7:master Jan 28, 2025
3 checks passed
@emilazy emilazy deleted the push-tunoqoxyyuvy branch January 28, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants