Multiplatform benchmarks baseline #4350
Conversation
qwwdfsad
changed the title
qwwdfsad
changed the title
|
I see that the |
| "--add-exports", "java.base/sun.security.action=ALL-UNNAMED", | ||
| "--add-exports", "java.base/jdk.internal.util=ALL-UNNAMED") // in the model checking mode | ||
| "--add-exports", "java.base/jdk.internal.util=ALL-UNNAMED" | ||
| ) // in the model checking mode |
There was a problem hiding this comment.
Pro tip: use Difftastic when reviewing such changes! In a structural diff, the trivial formatting edits don't show up at all.
| dependencies { | ||
| implementation("org.jetbrains.kotlinx:kotlinx-benchmark-runtime:${version("benchmarks")}") | ||
| } | ||
| dependsOn(bmm) |
There was a problem hiding this comment.
Why is bmm needed? Is using benchmarkMain (defined above) worse?
| kotlin.srcDir("benchmarks/main/kotlin") | ||
| } | ||
|
|
||
| ss.create("jvmBenchmark") { |
There was a problem hiding this comment.
Where does the inconsistency with val benchmarkMain come from? Why not val jvmBenchmark by creating {?
| @@ -58,6 +60,7 @@ kotlin { | |||
| implementation("org.openjdk.jol:jol-core:0.16") | |||
| } | |||
| } | |||
| setupBenchmarkSourceSets(this) | |||
There was a problem hiding this comment.
Why is this a separate function? Simply for the sake of readability, or are there other motives?
Also, I'd prefer setupBenchmarkSourceSets(sourceSets) outside the sourceSets block, so that it's clearer what gets passed as the parameter.
There was a problem hiding this comment.
For the sake of readability, to confine benchmark configuration which is far from trivial.
If it were benchmarks { jvm {} ...}, I would have left it here
| ./gradlew :kotlinx-coroutines-core:macosArm64BenchmarkBenchmark | ||
| // Figure out what to use | ||
| ./gradlew :kotlinx-coroutines-core:tasks | grep -i bench |
There was a problem hiding this comment.
| ./gradlew :kotlinx-coroutines-core:tasks | grep -i bench | |
| ./gradlew :kotlinx-coroutines-core:tasks | grep -i "BenchmarkBenchmark " |
Seems much more reliable.
I needed this for Kotlin/kotlinx-atomicfu#499 and decided to tidy it up a bit and make it usable.
Adding @fzhinkin to verify the sourcesets setup