Refer to DateTimeComponents field names in errors for null values #472
+96
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
reviewed
Feb 7, 2025
| if (i != index) fields[i].set(this) | ||
| } | ||
| } | ||
| fail("No error if the field ${fields[index].property.name} is unset") |
There was a problem hiding this comment.
This test pattern is usually covered with assertFailsWith<ExceptionType>
| PropertyAndItsValue(DateTimeComponents::nanosecond, 123_456_789), | ||
| PropertyAndItsValue(DateTimeComponents::offsetHours, 3), | ||
| PropertyAndItsValue(DateTimeComponents::offsetMinutesOfHour, 30), | ||
| PropertyAndItsValue(DateTimeComponents::offsetSecondsOfMinute, 15), |
There was a problem hiding this comment.
Is offsetIsNegative false by default?
Or null in offsetIsNegative is equivalent to false when formatting?
There was a problem hiding this comment.
Or null in
offsetIsNegativeis equivalent to false when formatting?
This one. We haven't explicitly designed this behavior, so we can discuss it if you think it's problematic.
dkhalanskyjb
force-pushed
the
better-error-messages-on-DateTimeComponents-formatting
branch
from
dfb061a to
553349f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #471