-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to disable dumping Dokka config file #3961
base: master
Are you sure you want to change the base?
Conversation
Dumping the Dokka config files is useful for debugging, but can interfere with task outputs. Here we add a flag that disables the dumping the config file by default, but we enable it for our own tests. Fix #3958
8df567d
to
b08ecab
Compare
curious: why can't we just remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't we just remove @OutputFile from dokkaConfigurationJsonFile but need an additional property to disable debug functionality?
Removing |
Okay, I see, thanks! The main thing that worries me is that we already have there two WDYT about small change: create a separate intermediate task (e.g
Yes, it looks like a bit more work, but I think that it might be worth it. WDYT? |
Ah, a separate task could work, yes. I would have to investigate. I see a problem with a It might work if we made a completely separate 'debug' task that builds and logs the config file, to avoid interfering with the 'production' task. |
Dumping the Dokka config files is useful for debugging, but can interfere with task outputs.
Here we add a flag that disables the dumping the config file by default, but we enable it for our own tests.
Fix #3958