Add @AccessApiOverload annotations for API methods #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotated multiple methods with @AccessApiOverload to provide better API usability and to simplify overload selection for common use cases. The changes affect functions in various files, ensuring consistent application across the DataFrame API.
koperagen
reviewed
Jan 27, 2025
| @@ -429,13 +433,16 @@ public interface ColsColumnsSelectionDsl<out _UNUSED> { | |||
| * | |||
| * `df.`[`select`][DataFrame.select]` { "myColumnGroup"`[`[`][String.cols]`columnA, columnB`[`]`][String.cols]` }` | |||
| */ | |||
| @AccessApiOverload | |||
There was a problem hiding this comment.
There are a few annotation on doc interfaces. Need to be removed
Jolanrensen
reviewed
Feb 11, 2025
| public operator fun String.rangeTo(endInclusive: KProperty<*>): ColumnSet<*> = | ||
| toColumnAccessor().rangeTo(endInclusive.toColumnAccessor()) | ||
|
|
||
| /** | ||
| * @include [CommonRangeOfColumnsDocs] | ||
| * {@set [CommonRangeOfColumnsDocs.Example] `"fromColumn"`[`..`][String.rangeTo]`toColumn`} | ||
| */ | ||
| @AccessApiOverload |
There was a problem hiding this comment.
I don't think this must be annotated. We should still be able to write "someCol" .. someOtherCol if the compiler plugin does not recognize it has someCol.
We only want to remove KProperty overloads here, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1005 Related to #959
@koperagen could you please have a look? Am I correct, espicially with the col.kt file?