vkcubepp: Fix implicit cast compiler warnings #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1. std::tolower() returns an `int` value. Implicit converting an `int` to a `char` may trigger compiler warnings (-Wconversion on gcc and clang). This change adds an explicit cast to suppress the implicit conversion warnings. 2. Previously we used `assert(!"....")` to show error messages. This does an implicit conversion from `const char*` to `bool` which triggers compiler warnings (-Wconversion). This change replaces it with `assert(false && "...")` which doesn't trigger the warning. Bug: https://fxbug.dev/378964821 Change-Id: I51be6858db558568619d0d2e6bc01a544d3459e4
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
gnoliyil
changed the title
charles-lunarg
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intvalue. Implicit converting anintto acharmay trigger compiler warnings (-Wconversion on gcc and clang).This change adds an explicit cast to suppress the implicit conversion warnings.
assert(!"....")to show error messages. This does an implicit conversion fromconst char*toboolwhich triggers compiler warnings (-Wconversion).This change replaces it with
assert(false && "...")which doesn't trigger the warning.Bug: https://fxbug.dev/378964821