gn: Add _GNU_SOURCE definition to Linux builds #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GN-based linux-x64 builds, with the _GNU_SOURCE definition, the compiler will now have readlink() and strtok_r() declared. This is consistent to the build configurations defined in loader/CMakeLists.txt. Change-Id: If39f3b375e77fa1d0a9068123d04e516e166716a
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
charles-lunarg
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GN-based linux-x64 builds, with the _GNU_SOURCE definition, the compiler will now have readlink() and strtok_r() declared.
This is consistent with the build configurations defined in loader/CMakeLists.txt.