loader: Support latest Fuchsia build #1660
Conversation
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
gnoliyil
force-pushed
the
fuchsia-support
branch
from
b5ed865 to
436914a
Compare
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
gnoliyil
force-pushed
the
fuchsia-support
branch
from
436914a to
7843c6e
Compare
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
gnoliyil
force-pushed
the
fuchsia-support
branch
from
7843c6e to
b6802c4
Compare
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
This change merges the Fuchsia-forked Vulkan-Loader branch into the upstream. Since last update (KhronosGroup#478), there has been significant changes to the way for Vulkan Loader to get manifests and the way for Vulkan ICDs to get I/O access to GPU devices. Also, Fuchsia has completely dropped C bindings for the FIDL API which `dlopen_fuchsia.c` uses. This change makes the following changes: * Add `loader_extensions_fuchsia.{cc,h}`. This allows the Vulkan Loader to provide a way to allow I/O to GPU devices to the ICDs it opens. The extended ICD API is defined in https://fuchsia.dev/fuchsia-src/ contribute/governance/rfcs/0205_vulkan_loader and it's implemented on ICDs like Fuchsia's Intel Mesa ICD: https://fuchsia.googlesource.com/third_party/mesa/+/main/src/intel/ vulkan/anv_magma.c * Access data and manifest files from manifest file system FD: The Fuchsia Vulkan loader service provides manifests using a service-provided virtual file system. It creates these filesystems based on the contents of multiple ICD packages and services it receives through devfs. As a result, they must be constructed using a filesystem serving library and don't reflect anything on-disk (see https://fuchsia.dev/fuchsia-src/contribute/governance/ rfcs/0205_vulkan_loader#filesystem_serving for details). The service-provided file system can be only opened as an FD using Fuchsia's FDIO (https://fuchsia.googlesource.com/fuchsia/+/main/sdk/ lib/fdio) library. Thus, in order to read manifest files located in a directory opened as an FD, we need to add a `parent_dir_fd` param to the functions that read files, including `loader_get_json` and `add_data_files`. * Migrated to the C++ FIDL bindings. The old C bindings are not supported anymore and have been deleted from the Fuchsia tree. This change migrates `dlopen_fuchsia` to use the C++ wire bindings (https://fuchsia.dev/fuchsia-src/reference/ fidl/bindings/cpp-bindings) which is part of the Fuchsia SDK. Test: libvulkan builds on Fuchsia with the changes above. Bug: https://fxbug.dev/378964821 Change-Id: I2af9f677d706d07193aecd2dcc4640ec602b138f
gnoliyil
force-pushed
the
fuchsia-support
branch
from
b6802c4 to
7d5e121
Compare
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author gnoliyil not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 377418. |
|
CI Vulkan-Loader build # 2924 running. |
|
CI Vulkan-Loader build # 2924 passed. |
This change merges the Fuchsia-forked Vulkan-Loader branch into the upstream. Most of the changes were previously authored and reviewed by @jbauman42 (left Google) and @cdotstout .
Since last update (#478), there has been significant changes to the way for Vulkan Loader to get manifests and the way for Vulkan ICDs to get I/O access to GPU devices. Also, Fuchsia has completely dropped C bindings for the FIDL API which
dlopen_fuchsia.cuses.This change makes the following changes:
Add
loader_extensions_fuchsia.{cc,h}. This allows the Vulkan Loader to provide a way to allow I/O to GPU devices to the ICDs it opens.The extended ICD API is defined in Fuchsia RFC-205: Vulkan Loader and it's implemented on ICDs like Fuchsia's Intel Mesa ICD.
Access data and manifest files from manifest file system FD:
The Fuchsia Vulkan loader service provides manifests using a service-provided virtual file system. It creates these filesystems based on the contents of multiple ICD packages and services it receives through devfs. As a result, they must be constructed using a filesystem serving library and don't reflect anything on-disk (see Fuchsia RFC-205 Section "Filesystem serving" for details).
The service-provided file system can be only opened as an FD using Fuchsia's FDIO library. Thus, in order to read manifest files located in a directory opened as an FD, we need to add a
parent_dir_fdparam to the functions that read files, includingloader_get_jsonandadd_data_files.Migrated to the C++ FIDL bindings.
The old C bindings are not supported anymore and have been deleted from the Fuchsia tree. This change migrates
dlopen_fuchsiato use the C++ wire bindings which is part of the Fuchsia SDK.Test: libvulkan builds on Fuchsia with the changes above.
Bug: https://fxbug.dev/378964821