Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Update minimum version to 3.22.1 #2071

Closed
wants to merge 2 commits into from

Conversation

M2-TE
Copy link
Contributor

@M2-TE M2-TE commented Feb 11, 2025

Updated to match Vulkan-Headers, Vulkan Validation Layers and SPIR-V Tools.
See KhronosGroup/Vulkan-Headers#525

Removed ci for ubuntu-20.04 as it only ships CMake 3.16.3

@asuessenbach
Copy link
Contributor

I don't see why we should push the CMake minimum version to 3.22.1. We can live with what we have, can't we?

@M2-TE
Copy link
Contributor Author

M2-TE commented Feb 11, 2025

The plan was to add Vulkan-Headers via add_subdirectory or FetchContent instead of just adding the include directory, as we could make use of their version check and also prevent the currently duplicated header files (vulkan.hpp is present in both Vulkan-Headers and Vulkan-Hpp), while also providing the Vulkan::Headers target, if people need it.

These things are not strictly necessary, but I figured it would make sense to update to the same version as the Vulkan-Headers dependency, which would also enable some extra aforementioned things. A version range via 3.12...3.22.1 might also do the trick to not place any hard requirements.

If you think it's not needed, feel free to just close this PR!

@asuessenbach
Copy link
Contributor

In fact, I don't think, it's needed.
And what's more important here: I don't like to cut down the CI by removing the checks on Ubuntu 20.04, just to keep CMake happy.
That is: as long as there's no substantial reason to require a newer version of CMake I'd like to stay with it.

@M2-TE M2-TE deleted the cmake-version-update branch February 17, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants