-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Location Component chapter #292
base: main
Are you sure you want to change the base?
Add Location Component chapter #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for clarity and a few fixes. I think it would also be a good idea to have a 64-bit example, particularly a 64-bit vec3/4, showing how these consume multiple locations, and how these have to be aligned to even components.
|
||
[source,glsl] | ||
---- | ||
layout(location=0) in f64vec3 a; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also be a good idea to have a 64-bit example, particularly a 64-bit vec3/4
Here is that example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this chapter provide guidance on whether the number of locations ought to be minimized? Maybe it should also mention that you can't mix interpolation within a location?
+ layout(location=0, component=2) in float in_f; | ||
---- | ||
|
||
== Array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once Vulkan issue 4180 is clarified it would be good to expand this section I think
|
08fe7d5
to
04c334e
Compare
@alan-baker for the
Did you mean between two stages? (I plan to have another possible guide about connecting the Location) As for what I think you mean, it seems that GLSL disallows it, but not |
Yes, I know spirv-val doesn't check it. It's good that glslang does, but it's one of those things for new frontends that is sort of a gotcha that's not easy to find. |
@Tobski @alan-baker - Here is a simple chapter around our favorite topic of
Location
/Component
(latest commit rendered version - https://github.com/KhronosGroup/Vulkan-Guide/blob/04c334e94c08470961bf4ebfc13520b907acc884/chapters/location_component_interface.adoc)