[KT-75060] Fir FileBasedKotlinClass parse innerclass with 1.1.16 metadata library compatibility #5403
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryxiao625
force-pushed
the
KT-75060/annotation_inner_type_annotation_compatibility
branch
from
217d782 to
ff67271
Compare
When using a project dependency library which compiled by 1.3.72 or below kotlin version, metadata is 1.1.6 or below, an issue occurs when referencing an enum defined as an inner class using in the annotation. This leads to an issue similar to: Unresolved reference: <Strange deserialized enum value: androidx/annotation/RestrictTo/Scope.LIBRARY>#' type=androidx.annotation.RestrictTo.Scope Caused by metadata 1.1.6 and below library missing the innerclass struct for annotation type, add a fallback logic for internal class parsing to convert the jvm classname for $ symbol See KT-75060 Issue with FileBasedKotlinClass InnerClass Parse with 1.1.16 Metadata Compatibility ^KT-75060 Fixed
larryxiao625
force-pushed
the
KT-75060/annotation_inner_type_annotation_compatibility
branch
from
ff67271 to
ab5d869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a project dependency library which compiled by 1.3.72 or below kotlin version, metadata is 1.1.6 or below, an issue occurs when referencing an enum defined as an inner class using in the annotation. This leads to an issue similar to: Unresolved reference: <Strange deserialized enum value: androidx/annotation/RestrictTo/Scope.LIBRARY>#' type=androidx.annotation.RestrictTo.Scope
Caused by metadata 1.1.6 and below library missing the innerclass struct for annotation type, add a fallback logic for internal class parsing to convert the jvm classname for $ symbol
See KT-75060 Issue with FileBasedKotlinClass InnerClass Parse with 1.1.16 Metadata Compatibility
^KT-75060 Fixed