Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Fix Regex handling of matches and matchEntire #5402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JS] Fix Regex handling of matches and matchEntire #5402

wants to merge 1 commit into from

Conversation

Vampire
Copy link

@Vampire Vampire commented Feb 6, 2025

No description provided.

@Vampire Vampire mentioned this pull request Feb 6, 2025
Merged
@Vampire
Copy link
Author

Vampire commented Feb 6, 2025

Without this PR matches on JS does not consider whether the full input would match the pattern if a shorter match is the first result and matchEntire tries to be overly clever, horribly failing to do the right thing. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vampire