Fix excessive recompositions in SelectableLazyColumn #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that reacts to selected keys change was triggering too often and causing issues with excessive recompositions, who could cascade into weird scrolling/state management issues.
hamen
approved these changes
Dec 11, 2024
hamen
added a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 14, 2025
|
Migrate to IJP as JetBrains/intellij-community#2905 |
intellij-monorepo-bot
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
Jan 15, 2025
reference JetBrains/jewel#723 closes #2905 GitOrigin-RevId: c7cf1e0405ac1894c7318627381dfb39dd0e0b20
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
reference #723 closes JetBrains/intellij-community#2905 GitOrigin-RevId: c7cf1e0405ac1894c7318627381dfb39dd0e0b20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that reacts to selected keys change was triggering too often and causing issues with excessive recompositions, which could cascade into weird scrolling/state management issues.