[JEWEL-761] Fix modifier handling in Link #2942
Open
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bug in Link where, when it was enabled, it would essentially ignore the passed in Modifier. The fix is simple, but the issue was tricky to spot, as it's quite subtle! This also: * Adds a test to avoid regressions * Restores the ui-tests module, which was removed from the Gradle build by mistake (probably during a rebase/merge) * Restores the git hook setup on non-Windows OSes (it is only broken on Windows) and proposes a solution for Windows for Kuba to test
rock3r
force-pushed
the
fix-link-modifier
branch
from
1fde39e to
6f178db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug in
Linkwhere, when it was enabled, it would essentially ignore the passed in Modifier. The fix is straightforward, but the issue was tricky to spot, as it's quite subtle!This also: