[JEWEL-725] Upgrade Compose to 1.8.0-alpha02 #2927
Open
+1,194
−978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamen
approved these changes
Jan 23, 2025
hamen
force-pushed
the
sebp/jewel-725_upgrade-compose
branch
from
5df5c4b to
a0169b1
Compare
|
Do I understand correctly that we are instead waiting for non broken release of compose? Or alpha02 is already fixed? |
|
@jakub-senohrabek no, this version is fine. alpha03's publication is problematic and we'll skip it. The GitHub CI was interrupted for some unknown reason. |
|
After talking to the CMP team, it looks like we might want to wait for beta01, that should be out in a couple weeks. |
|
False alarm, we're ok with alpha02. The potential binary incompatibility affects other CMP targets, not desktop. |
rock3r
force-pushed
the
sebp/jewel-725_upgrade-compose
branch
2 times, most recently
from
126889c to
f80b830
Compare
This updates both the JPS and the Gradle builds. Includes bumping Skiko to 0.8.19, and switching from the combined runtime-all dependency to the separate per-platform dependencies. This also extends the Explicit API mode to tests, too, aligning us with the JPS project, where it can't only be applied to prod code. The deprecation warnings in the buildSrc have been addressed, too. ScrollingSynchronizerTest markdown indenting has been cleaned up
rock3r
force-pushed
the
sebp/jewel-725_upgrade-compose
branch
from
f80b830 to
0326c40
Compare
|
Not sure why an explicit merge was needed, since there were no actual conflicts, but at least GitHub won't be complaining about it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates both the JPS and the Gradle builds.
Includes bumping Skiko to 0.8.19, and switching from the combined runtime-all dependency to the separate per-platform dependencies.
Caution
Requires #2913 to be merged first
Supersedes #2896
Closes JetBrains/jewel#725