Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources improvements for native macOS app #5219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thomas-Vos
Copy link
Contributor

@Thomas-Vos Thomas-Vos commented Jan 28, 2025

See old PR for details: #5169

Requires skiko update (JetBrains/compose-multiplatform-core#1804)

@Thomas-Vos
Copy link
Contributor Author

@terrakok Skiko is now already updated on jb-main branch. Would it be possible to run CI on this PR to check if all is working?

@Thomas-Vos Thomas-Vos force-pushed the resources-improvements-macos branch from e22b11b to e5d45f2 Compare February 9, 2025 23:32
@Thomas-Vos
Copy link
Contributor Author

@terrakok tested on an Intel Mac and the tests now pass with the updated skiko version:

Screenshot 2025-02-10 at 00 33 52

In gradle-plugins module I set compose.version=1.8.0+dev2049 in gradle.properties and used local build of resources lib (set 0.1.0-SNAPSHOT version for resources in ComposePlugin.kt).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant