vulkan-validationlayers 1.4.309

[BrewTestBot]

Created by brew bump

---

Created with brew bump-formula-pr.

• resource blocks have been checked for updates.

[cho-m]

I wonder if we should align with SDK releases instead.

This would allow us to match with SPIRV releases and avoid the resources (as SDK's components should be compatible)

[chenrui333]

I wonder if we should align with SDK releases instead.

This would allow us to match with SPIRV releases and avoid the resources (as SDK's components should be compatible)

I dont think they are always in sync?

  # https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/v#{version}/scripts/known_good.json#L32
  resource "SPIRV-Headers" do
    url "https://github.com/KhronosGroup/SPIRV-Headers.git",
        revision: "2b2e05e088841c63c0b6fd4c9fb380d8688738d3"
  end
  # https://github.com/KhronosGroup/Vulkan-ValidationLayers/blob/v#{version}/scripts/known_good.json#L46
  resource "SPIRV-Tools" do
    url "https://github.com/KhronosGroup/SPIRV-Tools.git",
        revision: "066c3d52c2fca8d9df79ca37055c3f5eddf2ffce"
  end

[cho-m]

I dont think they are always in sync?

The SDK is designed to be compatible. SDK is a state of all components that get shipped together in a full package - https://vulkan.lunarg.com/sdk/home#mac

known_good is just a single confirmed test point. There is often no need to be on exact version specified there for same reason we don't vendor every dependency. As long as within an API/ABI compatible version, which SDK provides.

[cho-m]

To give an example,

• Fedora: https://packages.fedoraproject.org/pkgs/vulkan-validation-layers/vulkan-validation-layers/fedora-rawhide.html
  • https://src.fedoraproject.org/rpms/vulkan-validation-layers/blob/rawhide/f/vulkan-validation-layers.spec#_8
  • https://src.fedoraproject.org/rpms/vulkan-validation-layers/blob/rawhide/f/vulkan-validation-layers.spec#_16
• Debian: https://packages.debian.org/source/trixie/vulkan-validationlayers
  • https://salsa.debian.org/xorg-team/vulkan/vulkan-validationlayers/-/blob/debian-unstable/debian/watch?ref_type=heads
  • https://salsa.debian.org/xorg-team/vulkan/vulkan-validationlayers/-/blob/debian-unstable/debian/control?ref_type=heads#L14

[chenrui333]

IIRC those were known_good.json was brought in when there was compatible issue before.

(yeah, we can always go back to the specific commit if the formulae do not work)

[cho-m]

IIRC those were known_good.json was brought in when there was compatible issue before.

But was that on the SDK release cycle (i.e. x.y.z releases with a vulkan-sdk-x.y.z tags, not those with only x.y.z tags), i.e.

• SDK release: https://github.com/KhronosGroup/Vulkan-Headers/releases/tag/vulkan-sdk-1.4.304.1
• non-SDK release: https://github.com/KhronosGroup/Vulkan-Headers/releases/tag/v1.4.309

SPIRV only provides releases on SDK cycle:

• https://github.com/KhronosGroup/SPIRV-Headers/releases/tag/vulkan-sdk-1.4.304.1