ci: enable new CI for eventarc/audit-storage #3969
Draft
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![code-review-assist[bot]](https://avatars.githubusercontent.com/in/1008254?s=60&v=4){kind=small}
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
product-auto-label
bot
added
samples
There was a problem hiding this comment.
This pull request enables a new CI for eventarc/audit-storage. The change looks good and correctly adds the necessary configuration. The addition of ci-setup.json is appropriate for the new CI runner. I have a few minor suggestions below.
I recommend updating the README file to reflect the enablement of the new CI, specifically mentioning the new CI runner and the purpose of the ci-setup.json file.
briandorsey
force-pushed
the
briandorsey_e-audit-storage
branch
from
6d5f62d to
556ea26
Compare
ignore ".github/config/" so changes to the configs aren't considered global changes (which cause all packages to be tested)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Batch CI related config change. Adding ci-setup.json to support running these tests under the new CI runner. No changes to tests themselves.