Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New blog post #326

Merged
merged 28 commits into from
Aug 6, 2024
Merged

New blog post #326

merged 28 commits into from
Aug 6, 2024

Conversation

bingling-sama
Copy link
Contributor

A new blog post addressing many core concepts in Minecraft

@github-actions github-actions bot requested review from Big-Cake-jpg and Seayay August 5, 2024 15:35
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for crashmc ready!

Name Link
🔨 Latest commit e5867f0
🔍 Latest deploy log https://app.netlify.com/sites/crashmc/deploys/66b19297b9a5060008597f0c
😎 Deploy Preview https://deploy-preview-326--crashmc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bingling-sama bingling-sama requested review from bingxin666, zyxkad and XieXiLin2 and removed request for Seayay August 5, 2024 15:41
XieXiLin2
XieXiLin2 reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@XieXiLin2 XieXiLin2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以用 ruff 格式化对齐表单边框。

zyxkad
zyxkad requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@zyxkad zyxkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有一些标点符号和语法问题

@bingling-sama
Copy link
Contributor Author

bingling-sama commented Aug 6, 2024 •
edited
Loading

可以用 ruff 格式化对齐表单边框。

表单边框是由 Obsidian 自动生成的，并非手写，是否对齐并不重要

@bingling-sama bingling-sama requested a review from XieXiLin2 August 6, 2024 01:51
@XieXiLin2 XieXiLin2 requested a review from zyxkad August 6, 2024 02:48
zyxkad
zyxkad approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@zyxkad zyxkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bingling-sama bingling-sama merged commit 06809e4 into GlobeMC:dev Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seayay Seayay Seayay left review comments

@bingxin666 bingxin666 bingxin666 approved these changes

@zyxkad zyxkad zyxkad approved these changes

@XieXiLin2 XieXiLin2 XieXiLin2 approved these changes

@Big-Cake-jpg Big-Cake-jpg Awaiting requested review from Big-Cake-jpg

@hejiehao hejiehao Awaiting requested review from hejiehao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bingling-sama @bingxin666 @zyxkad @Seayay @hejiehao @XieXiLin2