fix: set process working dir based on relative path of -f file too #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why === * extends now sets the working dir of the processes in it based on the relative path of the process-compose file. * The documentation says that -f should be equvalent to using extends * However, -f does not set the workign dir of the process to match the process-compose file's path * To make the documentation consistent again, we should also set the working dir for the -f filename case. What changed === * Move the working dir copy from loadExtendProject to loadProjectFromFile Test plan === * -f and extends both set the expected working dir of the processes in my local tests
ryantm
force-pushed
the
rtm-01-08-fix-working-dir-cli
branch
from
e50ae1a to
8b0f635
Compare
|
|
@F1bonacc1 gentle nudge here. Are you reticent about merging this because it breaks some backward compatibility with working dirs of CLI args? |
|
@F1bonacc1 Just checking in again, it's been a month. Any feedback for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What changed
Test plan