feat: Add mousedown and mouseup event #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is unactive an English word? I am a non native speaker, sorry for the stupid question. I know inactive and to deactivate but unactive is new to me |
|
No, I just kept the same naming convention as unhover. But I am very open to renaming variables. |
nicoburns
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
We'll need to think much more carefully about the interaction between:
- Handling events in dioxus vs. in DOM
- Bubbling events
- Triggering events based on other events (e.g. mousedown+mouseup triggering click, click sometimes triggering input or focus)
But this seems ok for now.
|
Be cool to get mousemove working as well. Then we could do mouse selection in text inputs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click events are triggered after the mouse is pressed and released, and on the same node.