Remove base path #10
Open
Remove base path #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we packed up the bull-board in docker, so base path should always be `\` differences: - PROXY_PATH: the path for web to load static files - BASE_PATH: the path for express server
|
it works on |
Diluka
force-pushed
the
remove-base-path
branch
2 times, most recently
from
84853b2 to
9e24f87
Compare
those path need add proxy prefix, so the browser can navigate to the right page
|
@Diluka i'll review soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base path should be
/, and it breaks proxy path settings