-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add campaign group selector #370
base: develop
Are you sure you want to change the base?
Conversation
Nightly build for this pull request:
|
da2d585
to
890abed
Compare
890abed
to
f356b26
Compare
f356b26
to
27a2678
Compare
d377097
to
8a25264
Compare
Ready for review now. Prerequisite #367. |
I'm not a fan of the design where the Battle.ini is constantly re-read and re-parsed here. I'd rather read Battle.ini only once, have all the missions in the |
Actually wouldn't it be better to have one INI per window? So separate screens would have different |
I think the single file gives more control when it comes to the "Show All" view. |
c659583
to
51208f1
Compare
Thanks for the suggestion. Code updated. |
51208f1
to
c500b57
Compare
This PR is backward compatible as by default the option is off. Modders can enable the
CampaignTagSelectorEnabled
option to use this feature.This feature enables modders to make a "choose your side" interface before the campaign selector. Choosing among "Act 1/Act 2/..." or any other tags is also possible.
The screenshot below shows the feature. (I am not an expert in beautifying user interfaces so it is only a working example. Fully configurable through ini files.)
The modders define tags for missions in
battle.ini
and customize the selector window inCampaignTagSelector.ini
using the new INItializableWindow ini format.I use TSC v6 client as an example. The corresponding files are attached here.
TSC.v6.example.zip
Prerequisite of this PR: #364 (merged now) and #367 (requesting merge).