Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Open questions:
If we're using ES Module workers, is that compatible with CJS builds?Workers will be ESM-only.If workers are opt-in or opt-out, what's the API to switch?Opt-out, bywidgetSourceWorker: false
option.If Microbundle generates named chunks likeReplaced microbundle with tsup.widget-tileset-worker-BXxfh1Ze.js
, is that compatible withpackage.json#exports
?These issues could probably be solved like deck.gl does, by publishing worker code to a CDN and loading that... But this makes builds and development more complicated, and CDNs may fail, I'd prefer to avoid the CDN.
The last version of Node.js that doesn't support
require(esm)
will reach end-of-life in April... maybe we can say Web Workers are available only for ESM builds? We can use an extra entrypoint (@carto/api-client/worker
) for the worker code.