Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix misplaced conditional #60

Merged
merged 1 commit into from
Feb 12, 2025
Merged

ci: Fix misplaced conditional #60

merged 1 commit into from
Feb 12, 2025

Conversation

ribose-jeffreylau
Copy link
Contributor

Fixes #59

@ribose-jeffreylau ribose-jeffreylau added the bug Something isn't working label Feb 11, 2025
@ribose-jeffreylau ribose-jeffreylau self-assigned this Feb 11, 2025
@ribose-jeffreylau ribose-jeffreylau marked this pull request as draft February 11, 2025 01:44
@ribose-jeffreylau
Copy link
Contributor Author

Before this PR is merged, perhaps the following should be addressed first:

@ronaldtse
Copy link
Contributor

Before this PR is merged, perhaps the following should be addressed first:

@ribose-jeffreylau can you please help fix this issue? Thanks.

@ronaldtse
Copy link
Contributor

@ribose-jeffreylau please merge this when ready.

@ribose-jeffreylau ribose-jeffreylau marked this pull request as ready for review February 12, 2025 03:17
@ribose-jeffreylau ribose-jeffreylau merged commit 776ea3f into main Feb 12, 2025
14 checks passed
@ribose-jeffreylau ribose-jeffreylau deleted the 59-ci branch February 12, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ribose-jeffreylau ribose-jeffreylau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI not deploying on main branch
2 participants
@ribose-jeffreylau @ronaldtse