Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean build process #58

Merged
merged 151 commits into from
Feb 10, 2025
Merged

Clean build process #58

merged 151 commits into from
Feb 10, 2025

Conversation

ronaldtse
Copy link
Contributor

No description provided.

@ronaldtse
Copy link
Contributor Author

@ribose-jeffreylau for your follow up. I'm not sure why your merged commits in #55 is showing up here...?

@ribose-jeffreylau
Copy link
Contributor

@ribose-jeffreylau for your follow up. I'm not sure why your merged commits in #55 is showing up here...?

I think I pushed my PR into main by mistake, when I thought I was pushing to the PR branch. For context, locally, I just set it up to remote-track Staging's main branch. I did a git push origin 55-build and it pushed to origin/main... Then I promptly undid the changes to origin/main.

@ronaldtse
Copy link
Contributor Author

@ribose-jeffreylau the aggregation step isn't correct yet, need your help to fix:

It's downloading all the artifacts but seem to not be merging correctly.

@ribose-jeffreylau
Copy link
Contributor

There are other issues apart from this. Paths to documents need adjustment, which I'm fixing now.

... Still needed for the scaffolding.
... to repopulate `metanorma.source.files` array of a target YAML, given a doc type, a document class,
and a sub-directory from which to search documents.
Command run:
  DOC_TYPE=administrative DOC_CLASS=cc scripts/repopulate-metanorma-yaml src-documents metanorma-admin.yml
Command run:
  DOC_TYPE=standard DOC_CLASS=cc scripts/repopulate-metanorma-yaml src-documents  metanorma-standards.yml
This reverts commit b6edba7.

Too many changes to deal with at a time.  Reverting.
@ribose-jeffreylau
Copy link
Contributor

@ronaldtse It should be ready for review.

@ronaldtse
Copy link
Contributor Author

Thank you @ribose-jeffreylau ! Finally we're done!

@ronaldtse ronaldtse merged commit 4d2f58a into main Feb 10, 2025
14 checks passed
@ronaldtse ronaldtse deleted the rt-clean-processing branch February 10, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants