Skip to content

Commit

Permalink
prevents knowledge conflicts on mangled names (#1535)
Browse files Browse the repository at this point in the history
This change prevents knowledge base conflicts that happen when we
apply name mangling on subroutines.
  • Loading branch information
ivg authored Jul 8, 2022
1 parent 46c93ca commit baa9022
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions lib/bap_types/bap_ir.ml
Original file line number Diff line number Diff line change
Expand Up @@ -314,11 +314,15 @@ end = struct
Bap_bitvector.string_of_value ~hex:true a
| None -> sprintf "%s%%%s" name (Tid.to_string tid)

let set_name_if_possible tid name =
try Tid.set_name tid name
with _ -> Tid.add_name tid name


let mangle_sub s =
let addr = Dict.find s.dict Bap_attributes.address in
let name = mangle_name addr s.tid s.self.name in
Tid.add_name s.tid s.self.name;
Tid.set_name s.tid name;
set_name_if_possible s.tid name;
let self = {s.self with name} in
{s with self}

Expand Down

0 comments on commit baa9022

Please sign in to comment.