Trailing backslashes and path highlighting

[danielshahaf]

Two cases:

1. BUFFER='print -r -- release.md\' highlights the backslash, but shouldn't. (Struck this out because it's debatable: see Trailing backslashes and path highlighting #666 (comment))

2. PREBUFFER='print -r -- release.md\' BUFFER='foo' highlights release.md\, even though none of that should be highlighted.

[phy1729]

I think the following would fix 2.

diff --git a/highlighters/main/main-highlighter.zsh b/highlighters/main/main-highlighter.zsh
index fe58398..cfc86a4 100644
--- a/highlighters/main/main-highlighter.zsh
+++ b/highlighters/main/main-highlighter.zsh
@@ -365,7 +365,12 @@ _zsh_highlight_highlighter_main_paint()
     unset X_ZSH_HIGHLIGHT_DIRS_BLACKLIST
   fi
 
-  _zsh_highlight_main_highlighter_highlight_list -$#PREBUFFER '' 1 "$PREBUFFER$BUFFER"
+  local buf=$PREBUFFER$BUFFER offset=-$#PREBUFFER
+  if [[ $PREBUFFER[-2,-1] == $'\\\n' ]];  then
+    buf=${PREBUFFER[1,-3]}$BUFFER
+    (( offset += 2 ))
+  fi
+  _zsh_highlight_main_highlighter_highlight_list $offset '' 1 $buf
 
   # end is a reserved word
   local start end_ style

As for the first, I don't know what else we'd do. While the trailing slash indicates another character will be typed, we don't know what it will be and so the dequoting just strips it (if memory serves). The backslash is still part of the word just as much as the quotes in 'release.md'.

[danielshahaf]

As for the first, I don't know what else we'd do. While the trailing slash indicates another character will be typed, we don't know what it will be and so the dequoting just strips it (if memory serves). The backslash is still part of the word just as much as the quotes in 'release.md'.

Regardless of what comes next, the \ won't be part of a filename when the command-line is completed, so it shouldn't be underlined.

I think the following would fix 2.

Thanks, but it doesn't.

By the way, another case (call it 3): PREBUFFER=': release.md\' BUFFER=$'\x20foo'. In this case I'd say the backslash shouldn't be underlined.

[danielshahaf]

Related: #665 (comment)

[danielshahaf]

Regardless of what comes next, the \ won't be part of a filename when the command-line is completed, so it shouldn't be underlined.

That's not actually correct: if the next character is a literal newline, the backslash-newline sequence will be elided entirely from argv of the builtin run.

[danielshahaf]

As for the first, I don't know what else we'd do. While the trailing slash indicates another character will be typed, we don't know what it will be and so the dequoting just strips it (if memory serves). The backslash is still part of the word just as much as the quotes in 'release.md'.

I've withdrawn (1).

I think the following would fix 2.

Cross-referencing #705.

[danielshahaf]

This is hairy. The highlighting of release.md in $PREBUFFER depends on the contents of $BUFFER, but we can't change the highlighting of $PREBUFFER as a function of the contents of $BUFFER, can we?