sudo and commands only in /sbin

[Raizo62]

Hi

Sorry, i come back for an other problem with sudo

With "sudo ls" , "ls" is colorized correctly with green

with "sudo ifup" where "ifup" is only in "/sbin", "ifup" is colorized in red

[danielshahaf]

with "sudo ifup" where "ifup" is only in "/sbin", "ifup" is colorized in red

Known issue. z-sy-h looks for commands in $PATH, but sudoers(5) can define an alternative path for root. Both the path value and the directories specified therein may be unreadable by non-root users, so there's no way to fix this in the general case. Ideas are welcome though.

[Raizo62]

Can z-sy-h define a specific variable used only with "sudo" code of z-sy-h which contains default path of root's commands (as /sbin).
If an user defines an alternative path for root in sudoers, then he can modify this variable ?

[danielshahaf]

Can z-sy-h define a specific variable used only with "sudo" code of z-sy-h which contains default path of root's commands (as /sbin). If an user defines an alternative path for root in sudoers, then he can modify this variable ?

Such users would also need to send the command-path style in the :completion:*:sudo:* zstyle context. It would be nice to have completion and z-sy-h both obtain the value from the same place.

[Raizo62]

On my zsh, the completion of "ifup" fails, and the completion of "sudo ifup" successes.
How the completion of zsh works ?

I want to install z-sy-h on OS for students in System Administration (Live Raizo), but it's very annoying if it shows a bad information : ifup is correct only behind sudo (if i am not root). And i can't add "/sbin" in the path of user (and it is not realistic)

[danielshahaf]

zstyle ":completion:*:sudo:*" command-path /bin /sbin .... Please ask further completion questions on zsh-users@ or #zsh on FreeNode to distribute the workload.

/sbin is in users' PATH on FreeBSD.

Good luck with your course!

[Raizo62]

zstyle ":completion:*:sudo:*" command-path /bin /sbin .... Please ask further completion questions on zsh-users@ or #zsh on FreeNode to distribute the workload.

Sorry, i believe that i was not been clear : I didn't ask how to do the completion on zsh for /sbin.
I said that the completion of zsh can have different actions with the word "sudo" .
When i am user, the completion of zsh doesn't show "ifup" , but if i use the word "sudo", zsh shows "ifup"
Then my question was : why can z-sy-h not do the same ?

/sbin is in users' PATH on FreeBSD.

It is not in Debian, and i think that is a good thing ;-)

[danielshahaf]

Because that hasn't been implemented. Patches welcome.

[Raizo62]

I can try....

[danielshahaf]

Great! Let's open a new issue to discuss possible approaches.

[Raizo62]

I think to add in "_zsh_highlight_main__type" something as
if $(sudo which "$1" >/dev/null) ; then; REPLY=command; fi
But this command must be called only if i am in "sudo" command. Perhaps can i add a new parameter at the function _zsh_highlight_main__type ?
But do you have already a variable to know if we are in sudo command ?

[danielshahaf]

-1. It is unacceptable to run sudo from z-sy-h.

[danielshahaf]

Knowing whether the command word is sudo is easy.

[Raizo62]

-1. It is unacceptable to run sudo from z-sy-h.

Ok, it's more complicated, but you're right.

And with this code ?

declare -a PATH_ROOT=("/sbin/" "/usr/sbin" "/usr/local/sbin")
if [ -n "$(find "$PATH_ROOT[@]" -maxdepth 1 -name "$1" -print -quit)" ]; then REPLY=command; fi

[danielshahaf]

This is plausible. We can't solve the general case, but a solution that's sound though not complete is worth consideration.

[danielshahaf]

@phy1729 @nicoulaj WDYT?

(Yes, it should be rewritten with a nullglob; I'm asking about the functionality and approach, not implementation.)