Implement changes from INSPIRE schema migration to PostNAS alignments #26
Conversation
annat2022
force-pushed
the
migrate-newInspireSchemas
branch
from
1533545 to
8936a3c
Compare
There was a problem hiding this comment.
commit message a84beae - I assume a "not is missing": "Additionally, changes in groovy script could not be applied automatically, therefore the groovy scripts were adapted manually."
Also, the comments in the diff files seem to be cut - commented at some places where that happened but stopped when I realised it is a systematic issue.
For the content: I roughly reviewed as far as I could but I am not familliar with the tool. So if you feel like a strict content review is needed, it would be great, if you could add Florian as a reviewer.
Indeed, adapted it accordingly.
That's not an issue at all as far as I can say. That's just how the diff file is generated automatically. I'm not super familiar with that, but for me it looks like that these lines are the header, defining the row where the change refers to and the content of this row. If the row is too long, seems the sentence is cut (but we can ignore that, that's not a change at all):
I assume this should be sufficient. IIRC when Florian reviewed similar tasks he did re-run the migration-tasks and checked if there are more changes (there should be none) and reviewed the manual changes. In this case I mainly ran the automatic migration, only if needed adapted the existing diff-file to apply it correctly, but all in all there were nearly no manual changes needed. And one additional thing: Seems that I missed to add the diff-files for |
annat2022
force-pushed
the
migrate-newInspireSchemas
branch
from
6e4fbb9 to
916cdbd
Compare
No manual changes were needed, only the automatic migration was run. SVC-1974
Namespaces in the existing diff file were updated and the existing diff file was applied. Additionally, changes in groovy script could not be applied automatically, therefore the groovy scripts were adapted manually. Changes due to the new INSPIRE schema in the groovy scripts to 'functionalClass' and 'verticalPosition' were applied manually. SVC-1974
Namespace were adapted in the existing manual-diff manually. With this the existing diff file was applied cleanly. No further manual changes were needed, the automatic migration ran successfully. SVC-1974
Namespace were adapted in the existing manual-diff manually. With this the existing diff file was applied cleanly. No further manual changes were needed, the automatic migration ran successfully. SVC-1974
Automatic migration ran successfully, no manual changes were needed. SVC-1974
Namespace were adapted in the existing manual-diff manually. With this the existing diff file was applied cleanly. No further manual changes were needed, the automatic migration ran successfully. SVC-1974
Automatic migration ran successfully, no manual changes were needed. Additionally the diff-file was adapted manually for the change related to the cell with id="C8dac57f2-ccc4-4666-997a-6900aedfd82a". Here a value for'AdministrativeUnit.UpperLevelUnit' is assigned. When running the migration with windows the respective change is added automatically (and there it is contained in the updated alignment). But when running the task with Linux it was necessary to add the change manually. There the namepsace in the diff-file was adapted manually and kept. SVC-1974
annat2022
force-pushed
the
migrate-newInspireSchemas
branch
from
916cdbd to
edbe5f8
Compare
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
SVC-1974