Skip to content

Mass values for walkthrough are off by orders of magnitude #43

Open
@charlesreid1

Description

Hi there,

I was going through the walkthrough notebook and noticed that when the images are imported with the line f = tp.locate(frames[0], 11, invert=True), the mass values are O(1)-O(10). However, several cells down there is a f = tp.locate(frames[0], 11, invert=True, minmass=200) call that wipes out all of the features found. Here's an example of what I'm seeing from f['mass'].head():

f['mass'].head()

0    1.211087
1    2.187542
2    1.501123
3    1.333051
4    1.533473
Name: mass, dtype: float64

From the image of the histogram embedded in the notebook, it appears that the (now un-reproducible) output from the masses column was O(1000). It seems this is related to the change in the way mass was calculated in version 0.3.0 (based on this comment in feature.py). I plan to submit a pull request to the walkthrough notebook with updated plots, but I wanted to run it past you first and see if you think the change in version 0.3.0 was, in fact, the cause.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions