Skip to content

Open issues for major release #301

Open
@tvdijen

Description

  • Upstream blocking issues in xml-security
  • AttributeValue must be able to deal with XML-structures as a value (i.e. Dutch national ID requires an EncryptedID there, but also EPTiD) (Fix AttributeValue to deal with complex content #340)
  • BaseID currently cannot be encrypted because it doesn't implement the encryption interfaces
  • Method getEncryptionBackend for any encryptable element is currently implemented to return null. Needs further implementation, or are we OK with the default?
  • SignedElementTestTrait needs to move to xml-security
  • Many setter-methods are still 'public' and should be migrated to 'protected'
  • We have to manually set $this->dataType = C::XMLENC_ELEMENT in the constructor of an encryptable element. It would be much cleaner if we could set a constant instead of 'abusing' the constructor for this. Will probably require changes to xml-security EncryptableElementTrait
  • We need a solution for the HTTPRequest binding.. It's currently not possible to migrate it to the new signing interface
  • We're not passing the container's blacklisted algorithms anywhere
  • grep -i TODO and fix those
  • Drop the Certificate/ directory and use the similar classes from xml-security
  • Rewrite the files in the Configuration/ directory. Create Configuration-classes for IdentityProvider and ServiceProvider with public getters/setters that can be used by implementations using this library.
  • The ecp:Request element has not yet been implemented (Add some more elements for the ecp-namespace #341)
  • The ecp:RelayState element has not yet been implemented (Add some more elements for the ecp-namespace #341)
  • The ecp:SubjectConfirmation element has not yet been implemented (Add some more elements for the ecp-namespace #341)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions