Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.
This repository has been archived by the owner on May 18, 2023. It is now read-only.

dev wheel renaming #46

Open
Open
@grlee77

Description

moving discussion here from #45

The renaming script assumes that the wheels built from master would have a commit hash in the version name:

e.g. 0.18.0.dev0+58dbafa where it would replace +58dbafa with the date.

but ours are just 0.18.0.dev0, so nothing gets replaced and no date is added.

I see a few possible ways to proceed:
1.) change scikit-image to add a hash to the version string
2.) modify the rename_wheel function to append the date without trying to replace an existing hash
3.) If we only intend to use this repo to build and upload tagged versions then no action is needed

@jni and @hmaarrfk : Do either of you have a preference?

Option 2 will be simpler if we don't care to have the version hash reported in skimage.version. Adding the version hash handling in SciPy does complicate their setup.py a bit

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions