Feature Req: Please support asdf

[jschank]

it would be nice to show supported package management information, from asdf.
asdf, is a more generic tool that does what nvm, rbenv, rvm, virtualenv all do.

[bobthecow]

I don’t use asdf, but pull requests are welcome :)

[jschank]

Hmm, i just started using it myself. I’ll see what i can figure out. Could be an interesting problem. Thanks, Schank

…

On Oct 25, 2017, 9:59 PM -0400, Justin Hileman ***@***.***>, wrote: I don’t use asdf, but pull requests are welcome :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[jschank]

HI there. I am working on adding the asdf functionality. I have forked the theme, and I have it installed locally. But I am unfamiliar with the best practices for contributing... For example, Should I create a branch on my forked repo, for the new work, Or should the commits just go straight onto master?

[jschank]

Heh, I think I figured it out. I have created a PR to add in ruby from asdf to the ruby prompt.
Note: I notice that by default, the theme attempts to not report the ruby version when it is the 'system' version. I think I would prefer to be able to always see what version of ruby is currently active (even if it is the global/system version - because the global version can be changed as well) Perhaps, the configuration setting for set -g theme_display_ruby no should allow options of yes|no|always