From 550833b061b31c15c9d1a1db17faebd4f1d80791 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 21 Nov 2022 12:44:09 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- deepwalk/types.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/deepwalk/types.py b/deepwalk/types.py index fc4102a..6ab0ef0 100644 --- a/deepwalk/types.py +++ b/deepwalk/types.py @@ -75,7 +75,26 @@ class TarPackage(Package): def unpack(self): with tarfile.open(name=self.item.real_path, mode='r:*') as tf: - tf.extractall(self.temp_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, self.temp_path) def bid_file(self): if tarfile.is_tarfile(self.item.real_path):