Default config does not find paths for dependencies

[kgreenek]

I love the idea of this plugin! I've been struggling with getting neovim to work well with python + bazel for a while now. Specifically, I have never been able to get it to reliably detect third party dependencies.

I tried this plugin out and it doesn't seem to be finding my external dependencies. Whenever I edit a file, the plugin generates a symlink in the directory for that package called pyrightconfig.json.

In my case, the extraPaths field doesn't seem to find my external packages.

I am using the default config like so in my packer config:

    use({
      "numine777/py-bazel.nvim",
      config = function()
        require("py-bazel").setup()
      end,
    })

There isn't anything special about my bazel repository. I am using rules_python to install the pip dependencies in the WORKSPACE.bazel file.

Any ideas on what I am missing? I'd really love to get this working! Thanks for any help.

[numine777]

This is partly my bad for not updating the README 😅 . You more than likely need to indicate the pip_deps_marker (which is the folder inside the external path that houses your third party python dependencies). I defaulted that to nil in the code, but also have a conditional that doesn't attempt to find external dependencies if that marker is nil. I work in a fairly opinionated bazel monorepo in my day job, so I know that we don't use the current bazel default, but if you are using a more standard bazel configuration, feel free to open a PR changing that default to whatever rules_python defaults to nowadays 😄

[kgreenek]

Ahhh I see. Unfortunately, I think the concept of a single folder under external that houses pip dependencies is just not compatible with how rules_python works.

In your WORKSPACE, you would use rules_python to do something like this: pip.parse points to a requirements.txt file with all your pip dependencies:

pip.parse(
    name = "pip",
    requirements_lock = "//:requirements_lock.txt",
)

Then under external, bazel downloads all of your pip dependencies under separate directories. I.E. each pip package gets its own folder under external named pip_[package_name]

Supporting multiple "markers" in your config could work, but you would have to list out all your dependencies explicitly -- and it wouldn't work if you work with multiple bazel repositories. Ideally those directories could be detected automatically by using a bazel query on the current target's deps. Then it wouldn't matter how your pip packages are installed.

[numine777]

Interesting! Yeah, if the external dir is the parent of the individual python deps, I can change the logic to use exeternal as the parent dir in the case that the marker is unlisted. As mentioned, there are other implementations of bazel that provide python deps differently, so this was more born of ignorance of the current pure bazel implementation (we use nix to provide python and its deps hermetically).

Alternatively, I'm very open to PRs if you need different behavior. Ultimately, I want to make this plugin as useful as possible 🙂