Skip to content

Using variable named PORT creates issues #4

Open
@inadarei

Description

It's a widely established standard for services (e.g. microservices) to consult with the PORT environmental variable on which port to bind to.

The fact that wait-for.sh uses a variable called "PORT" for internal needs gets in the way of this practice and can lead to fatal errors. Since the name of the local variable used for implementing wait-for.sh doesn't really matter, it should be renamed for something less common, e.g. WAIT_PORT

The generic names for HOST and TIMEOUT are less of a problem, possibly but while at it - probably a good idea to namespace them as well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions