Open
Description
It's a widely established standard for services (e.g. microservices) to consult with the PORT environmental variable on which port to bind to.
The fact that wait-for.sh uses a variable called "PORT" for internal needs gets in the way of this practice and can lead to fatal errors. Since the name of the local variable used for implementing wait-for.sh doesn't really matter, it should be renamed for something less common, e.g. WAIT_PORT
The generic names for HOST and TIMEOUT are less of a problem, possibly but while at it - probably a good idea to namespace them as well.
Metadata
Assignees
Labels
No labels
Activity