Library-index.json and Library-details.json are not available

[k0st7]

src/Data/Library-index.json and workers-site/Library-details.json are missing when running npm run build. If the are supposed to be generated automatically, can you specify the order in which build commands need to be executed after dependencies have been installed.

Also Mac OS X 10.2.8 HD.dsk is missing. Is it ok to remove it from src/disks.ts and script/disks.py

[alex-r-bigelow]

Total n00b to this (very cool!) project, with the same question. Just leaving notes from poking around, in case they're useful to anyone.

W.r.t. the correct order of commands (assuming you already have git, python3, and npm already set up) my best guess:

git clone git@github.com:mihaip/infinite-mac.git
cd infinite-mac
git submodule update --init --recursive

npm install

# you might do these next two differently, depending on how you prefer to python
python3 -m venv venv
source venv/bin/activate

pip3 install -r requirements.txt

# this next command fails for me, but I'm on WSL and don't have xcode, so I'm not
# surprised. Not 100% sure how essential they are; poking around in git blame,
# these next two feel really important for being able to mess with / publish custom
# disk images, but if you're just trying to build what's already in the repo, they may
# not matter? OR VERY LIKEY: these need to work!
npm run build-xadmaster
sudo -v ; curl https://rclone.org/install.sh | sudo bash

# Unsure whether these are supposed to work without the above two dependencies:
npm run import-disks
npm run import-cd-roms

I've tried commenting out the relevant OS X lines in script/disks.py, as well as checking out 2fcb4fe (the commit before the OS X image was added), but either way, I get this error from npm run import-disks:

Traceback (most recent call last):
  File "/home/home/Repositories/infinite-mac/scripts/import-disks.py", line 739, in <module>
    images.append(build_system_image(disk, temp_dir))
  File "/home/home/Repositories/infinite-mac/scripts/import-disks.py", line 500, in build_system_image
    with zipfile.ZipFile(input_path, "r") as zip:
  File "/usr/lib/python3.10/zipfile.py", line 1272, in __init__
    self._RealGetContents()
  File "/usr/lib/python3.10/zipfile.py", line 1339, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

... and this error from npm run import-cd-roms:

Traceback (most recent call last):
  File "/home/home/Repositories/infinite-mac/scripts/import-cd-roms.py", line 19, in <module>
    class InputManifest(typing.TypedDict):
  File "/home/home/Repositories/infinite-mac/scripts/import-cd-roms.py", line 22, in InputManifest
    cover_image: typing.NotRequired[str]
AttributeError: module 'typing' has no attribute 'NotRequired'

[mihaip]

Thanks for reporting this, I've pushed some changes to make things work a bit better (the README also lists them out more explicitly now):

• npm run build-xadmaster has been replaced by npm run build-tools and now handles Xcode not being available
• npm run import-disks handles the Mac OS X 10.2 image missing (it will generate a placeholder)
• npm run import-library placeholder can now be used to generate the Library-index.json and Library-details.json files

Let me know if you're able to build the project if you pull in the latest changes.

[mihaip]

@alex-r-bigelow the module 'typing' has no attribute 'NotRequired' is due to your using an older version of Python (NotRequired was added in 3.11). If it's too much of a hassle to update you can hack up the script to remove it (e.g. instead of typing.NotRequired[str] you can just say str).