From afa2f1bddc659e0732e0df7da29030e630d562c1 Mon Sep 17 00:00:00 2001
From: Soumik Sarkar <soumiksarkar.3120@gmail.com>
Date: Sun, 1 Jan 2023 15:05:03 +0530
Subject: [PATCH] Cache contests for a small duration during magic (#50)

Previously it was not cached at all. Handles change so we don't want to cache for too long.
---
 carrot/src/background/cache/contests-complete.js | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/carrot/src/background/cache/contests-complete.js b/carrot/src/background/cache/contests-complete.js
index 8d3b936..30ba6cc 100644
--- a/carrot/src/background/cache/contests-complete.js
+++ b/carrot/src/background/cache/contests-complete.js
@@ -19,6 +19,7 @@ Contest.IsRated = {
   LIKELY: 'LIKELY',
 };
 
+const MAGIC_CACHE_DURATION = 5 * 60 * 1000; // 5 mins
 const RATING_PENDING_MAX_DAYS = 3;
 
 function isOldContest(contest) {
@@ -82,15 +83,22 @@ export class ContestsComplete {
 
     // If the contest is finished, the contest data doesn't change so cache it.
     // The exception is during new year's magic, when people change handles and handles on the
-    // ranklist can become outdated.
+    // ranklist can become outdated. So cache it only for a small duration.
     // TODO: New users can also change handles upto a week(?) after joining. Is this a big enough
     // issue to stop caching completely?
-    if (isFinished && !isMagicOn()) {
+    if (isFinished) {
       this.contests.set(contestId, c);
       this.contestIds.push(contestId);
       if (this.contestIds.length > MAX_FINISHED_CONTESTS_TO_CACHE) {
         this.contests.delete(this.contestIds.shift());
       }
+      if (isMagicOn()) {
+        setTimeout(() => {
+          this.contests.delete(contestId);
+          this.contestIds = this.contestIds.filter((cid) => cid !== contestId);
+        },
+        MAGIC_CACHE_DURATION);
+      }
     }
 
     return c;